Respect 'very-magic' in 'jsAssignmentExpr' regexp #340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This regex was modified in 325c048, where the tokens `\(>\)\@!` were added. This was supposed to be a negative lookahead for a literal `>`. However, this didn't work because the regexp has the `\v` flag, so the regexp actually ended up matching nothing. Closes #333. Test Plan: Install the [gerw/vim-HiLinkTrace][HLT] plugin. Write `let x = 3` in a new JavaScript file. Place the cursor on the `x` and enter `:HLT<CR>`. Before the patch is applied, the `SynStack` and `HltTrace` fields of the message should be blank. Then, apply the patch, relaunch vim, and repeat the `HLT` command; the message should now contain `SynStack: jsAssignmentExpr->...`. [HLT]: https://github.com/gerw/vim-HiLinkTrace
Collaborator
|
LGTM. I appreciate the detailed description. Thanks! |
davidchambers
added a commit
that referenced
this pull request
Jan 2, 2016
Respect 'very-magic' in 'jsAssignmentExpr' regexp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This regex was modified in 325c048,
where the tokens
\(>\)\@!were added.This was supposed to be a negative lookahead for a literal
>.However, this didn't work because the regexp has the
\vflag,so the regexp actually ended up matching nothing.
Closes #333.
Test Plan:
Install the gerw/vim-HiLinkTrace plugin.
Write
let x = 3in a new JavaScript file.Place the cursor on the
xand enter:HLT<CR>.Before the patch is applied,
the
SynStackandHltTracefields of the message should be blank.Then, apply the patch, relaunch vim, and repeat the
HLTcommand;the message should now contain
SynStack: jsAssignmentExpr->....